Skip to content

Comments

fix: potential refence to undefined var in algoliasearch [backport 2.21]#13708

Closed
github-actions[bot] wants to merge 1 commit into2.21from
backport-13692-to-2.21
Closed

fix: potential refence to undefined var in algoliasearch [backport 2.21]#13708
github-actions[bot] wants to merge 1 commit into2.21from
backport-13692-to-2.21

Conversation

@github-actions
Copy link
Contributor

Backport a653199 from #13692 to 2.21.

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

## Checklist
- [X] PR author has checked that all the criteria below are met
- The PR description includes an overview of the change
- The PR description articulates the motivation for the change
- The change includes tests OR the PR description describes a testing
strategy
- The PR description notes risks associated with the change, if any
- Newly-added code is easy to change
- The change follows the [library release note
guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html)
- The change includes or references documentation updates if necessary
- Backport labels are set (if
[applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting))

## Reviewer Checklist
- [x] Reviewer has checked that all the criteria below are met
- Title is accurate
- All changes are related to the pull request's stated goal
- Avoids breaking
[API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces)
changes
- Testing strategy adequately addresses listed risks
- Newly-added code is easy to change
- Release note makes sense to a user of the library
- If necessary, author has acknowledged and discussed the performance
implications of this PR as reported in the benchmarks PR comment
- Backport labels are set in a manner that is consistent with the
[release branch maintenance
policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)

---------

Signed-off-by: Juanjo Alvarez <juanjo.alvarezmartinez@datadoghq.com>
(cherry picked from commit a653199)
@github-actions github-actions bot requested review from a team as code owners June 18, 2025 12:34
@pr-commenter
Copy link

pr-commenter bot commented Jun 18, 2025

Benchmarks

Benchmark execution time: 2025-06-18 13:30:24

Comparing candidate commit 09f358c in PR branch backport-13692-to-2.21 with baseline commit 89e8597 in branch 2.21.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 344 metrics, 2 unstable metrics.

@brettlangdon brettlangdon reopened this Jun 18, 2025
@brettlangdon brettlangdon enabled auto-merge (squash) June 18, 2025 14:37
@github-actions
Copy link
Contributor Author

CODEOWNERS have been resolved as:

releasenotes/notes/algoliasearch-dangling-ref-e7a5086104d1761b.yaml     @DataDog/apm-python
ddtrace/contrib/internal/algoliasearch/patch.py                         @DataDog/apm-core-python @DataDog/apm-idm-python

@github-actions github-actions bot added the stale label Jul 19, 2025
@github-actions
Copy link
Contributor Author

This pull request has been automatically closed after a period of inactivity.
After this much time, it will likely be easier to open a new pull request with the
same changes than to update this one from the base branch. Please comment or reopen
if you think this pull request was closed in error.

@github-actions github-actions bot closed this Jul 20, 2025
auto-merge was automatically disabled July 20, 2025 00:09

Pull request was closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants